Pull Request automation in krel release-notes #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
sig/release
puerco
changed the title
puerco
force-pushed
the
pull-request-automation
branch
2 times, most recently
from
47c2f5e
to
9a84972
Compare
|
For reference, kubernetes-sigs/release-notes#153 was automatically generated using these changes. |
|
I had forgotten to cc the team |
puerco
force-pushed
the
pull-request-automation
branch
from
9a84972
to
d875d4c
Compare
saschagrunert
approved these changes
May 20, 2020
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I'm merging this one and I'll start fixing the issue found in kubernetes-sigs/release-notes#153 |
k8s-ci-robot
removed
the
do-not-merge/hold
justaugustus
added
the
kind/feature
k8s-ci-robot
removed
the
needs-kind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR automates the creation of pull requests to update the release notes draft in
k/sig-releaseand the release notes website inksigs/release-notes. It mainly puts to work changes to the github library merged in #1287 and #1268 so most of the work was already in place.It also verifies that the repositories used by the user are actual forks of their kubernetes counterparts..
Which issue(s) this PR fixes:
Related to #834
Special notes for your reviewer:
I've broken the PR into two commits, one for the automation of the release notes draft and one for the website patches.
The website portion is a bit temporary and will be removed soon as we are about to begin implementing some changes to move the json files to a GCP bucket. I plan to refactor some of the release notes subcommand code before that.
Does this PR introduce a user-facing change?
After this patch, running krel with
--create-draft-pror--create-website-prwill now really create pull requests in github.